-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ripemd160 hash function with permutation #1120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Tabaie - I added additionally false positive ignores for the statticcheck. Our linters have become more strict. |
Tabaie
requested changes
Dec 5, 2024
Tabaie
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the permutation function used in ripemd160 and the full hash function. Hash function construction is similar to SHA2, except uses little endian encoding.
Implementing as a precompile for Linea will be done in a separate PR when the interfaces are fixed.
Type of change
How has this been tested?
How has this been benchmarked?
In SCS a block cost is approx 60k PLONKish constraints. Not very specific as there is overhead for initializing the lookup table for AND/XOR/OR computation.
Checklist:
golangci-lint
does not output errors locally